-
Notifications
You must be signed in to change notification settings - Fork 109
Re-work of arrays meta-data #1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lworld
Are you sure you want to change the base?
Conversation
👋 Welcome back fparain! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense - found a typo. Are you going to check this in with UseNewCode2 or you could add a global flag for this because I think you're going to need a new one?
|
||
class ClassLoaderData; | ||
|
||
// RefjArrayKlass is the klass for arrays of references |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have an extra j in this.
private: | ||
// Constructor | ||
RefArrayKlass(int n, Klass *element_klass, Symbol *name, bool null_free); | ||
static RefArrayKlass *allocate(ClassLoaderData *loader_data, int n, Klass *k, Symbol *name, bool null_free, TRAPS); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stars go with the types, ie ClassLoaderData* loader_data.
@fparain this pull request can not be integrated into git checkout array_klasses
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push |
First step: creation of refArrayKlass to describe references arrays, keeping Java type related code in objArrayKlass.
When run with -XX:+UseNewCode2 -Xshare:off, the VM uses refArrayKlass instances as meta-data for refefences arrays and objArrayKlass should not be instantiated directly anymore.
Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1452/head:pull/1452
$ git checkout pull/1452
Update a local copy of the PR:
$ git checkout pull/1452
$ git pull https://git.openjdk.org/valhalla.git pull/1452/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1452
View PR using the GUI difftool:
$ git pr show -t 1452
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1452.diff