-
Notifications
You must be signed in to change notification settings - Fork 113
8357474: [lworld] Consolidate load/store flat inline types #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cd74d47
Consolidate load/store of flat values
merykitty 09d4dda
add tests
merykitty 8173ef2
convert_from_payload
merykitty 99d2269
array
merykitty 1029080
fix array field calculations
merykitty b151571
fix array of nullable empty type
merykitty 77f145d
generalize weird layout
merykitty 5ac917f
typo
merykitty f7e3bd3
weird layout
merykitty a364b7a
cast_to_flat_array
merykitty e49bbc8
Merge branch 'lworld' into loadstoreflat
merykitty 0a945fe
remove ptr_type parameters
merykitty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
cast_to_flat_array
- Loading branch information
commit a364b7a1fdb43e9b7bf7262d7b85b608754ff8f9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this would be specific to the layout described in JDK-8357612? Wouldn't we also hit
vk->get_field_by_offset(vk->payload_offset(), false) == nullptr
when the null marker is atvk->payload_offset()
which would be totally fine?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The null marker at
vk->payload_offset()
is covered byvk->null_marker_offset_in_payload() == 0
, am I right?