-
Couldn't load subscription status.
- Fork 83
[FSSDK-11981] bug bash addressed #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSSDK-11981] bug bash addressed #1097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances logging for CMAB (Contextual Multi-Armed Bandit) cache operations and fixes a missing logger dependency. The changes add four new log message constants for different cache events and ensure the DefaultCmabService receives a logger instance to use these messages.
- Added four new log message constants for CMAB cache operations (ignore, reset, invalidate, and attributes mismatch)
- Injected logger dependency into
DefaultCmabServiceand added debug logging for cache operations - Optimized code by extracting
userIdto avoid repeatedgetUserId()calls
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/message/log_message.ts | Added four new log message constants for CMAB cache events |
| lib/core/decision_service/cmab/cmab_service.ts | Added logger usage for cache operations and optimized userId retrieval |
| lib/client_factory.ts | Passed logger instance to DefaultCmabService constructor |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary
Logging improvements for CMAB cache operations:
IGNORE_CMAB_CACHE,RESET_CMAB_CACHE,INVALIDATE_CMAB_CACHE,CMAB_CACHE_ATTRIBUTES_MISMATCH) inlib/message/log_message.ts.Added missing logger in
DefaultCmabService.Test plan
Existing test should pass
Issues