[GR-64701] Re-parse graphs in OptimizeLongJumpsTest. #11132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OptimizeLongJumpsTest checks the number of jmp/jcc in raw machine code.
In rare circumstances, constants (e.g., displacements) in the code can look like opcodes for jmp/jcc which can transiently fail the test.
To avoid this, the code is emitted again in such cases (up to three times) as it is unlikely that such constants are present multiple times in a row.
However, emitting the code again also requires the graph to be parsed again.
Otherwise, the graph will already be in an unexpected state when doing the second code emit.