Fix pip install if torch isn't already installed
#210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
Currently if you are working on a fresh new environment without
torchinstalled, you have issues when installing this package:This PR suggests different improvements:
pip installin a single line, useful to add this package in arequirements.txtfor instancetorchtoinstall_requiresinsetup.pyso that torch is installed after thepip installtorchtorequiresinpyproject.tomlso that torch is present before calling thesetup.pyand we avoid the error aboveYou can test this by doing: