Assignment #03 - Ready for your Review #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…functions. Now running Unittests - AS
Great work! One lesson here is: whatever the type of the file, it can be processed the same way: read as bytes and passed onto the web browser. Using a "b" in the `open` makes this a little bit easier. This makes Python read the file directly as bytes, so that they don't have to be converted into bytes in a later line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Joe,
Well, I made it though this assignment. I'm stuck on 2 tests that I couldn't quite figure out. Maybe we can take a look at these later tonight? Let me know if you have any questions.
Thanks,
Andy Simpson