Skip to content

Open pool for extension #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Open pool for extension #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
778ecf6
return new static so you can extend the class and override methods
Aug 23, 2018
29c7391
allow access to pools for method calling, but no override the pool
Aug 23, 2018
c214cb8
allow access to cachepool and tagstore pool for extension
Aug 23, 2018
c5ab3c9
update changelog
Aug 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Taggable/Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release.

## UNRELEASED

###Changed
* Use late static binding when creating a new instance
* Allow access to the pools
## 1.0.0

### Added
Expand Down
6 changes: 3 additions & 3 deletions src/Taggable/TaggablePSR6PoolAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ class TaggablePSR6PoolAdapter implements TaggableCacheItemPoolInterface
/**
* @type CacheItemPoolInterface
*/
private $cachePool;
protected $cachePool;

/**
* @type CacheItemPoolInterface
*/
private $tagStorePool;
protected $tagStorePool;

/**
* @param CacheItemPoolInterface $cachePool
Expand Down Expand Up @@ -75,7 +75,7 @@ public static function makeTaggable(CacheItemPoolInterface $cachePool, CacheItem
return $cachePool;
}

return new self($cachePool, $tagStorePool);
return new static($cachePool, $tagStorePool);
}

/**
Expand Down