Add return type annotation to future proof PSR-6 compatibility #271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on my open source project I noticed that my build was breaking due to warning raised by my tests. I have a transient dependency to this package and it's raising multiple potential, future incompatibility warning in the form of:
I decided to add the annotation for now rather than change the implementation and leave that for a future date.
UPDATE: I think this changes is still a nice to have, but it also turns out that the warning was raised by
symfony/phpunit-bridge. Credits to @mareg and @ciaranmcnulty for the additional input.PS: It would be really nice if you could also add the hacktoberfest-accepted label to this PR. I hope it helps. Thank you.