Skip to content

Commit 03cbb3e

Browse files
committed
Build com_dotnet shared by default
The official Windows builds and CI are doing this for ages, so it appears to be overdue to finally switch the actual default. Closes GH-16300.
1 parent dd4fc9a commit 03cbb3e

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

.github/scripts/windows/build_task.bat

-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ set CFLAGS=/W1 /WX
3636
cmd /c configure.bat ^
3737
--enable-snapshot-build ^
3838
--disable-debug-pack ^
39-
--enable-com-dotnet=shared ^
4039
--without-analyzer ^
4140
--enable-object-out-dir=%PHP_BUILD_OBJ_DIR% ^
4241
--with-php-build=%DEPS_DIR% ^

UPGRADING

+5
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,11 @@ PHP 8.5 UPGRADE NOTES
147147
PHP_RELEASE_VERSION are now always numbers. Previously, they have been
148148
strings for buildconf builds.
149149

150+
* COM:
151+
. The extension is now build shared by default; previously it defaulted to a
152+
static extension, although the official Windows binaries built a shared
153+
extension.
154+
150155
* FFI:
151156
. It is no longer necessary to specify the library when using FFI::cdef()
152157
and FFI::load(). However, this convenience feature should not be used in

ext/com_dotnet/config.w32

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// vim:ft=javascript
22

3-
ARG_ENABLE("com-dotnet", "COM and .Net support", "yes");
3+
ARG_ENABLE("com-dotnet", "COM and .Net support", "yes,shared");
44

55
if (PHP_COM_DOTNET == "yes") {
66
CHECK_LIB('oleaut32.lib', 'com_dotnet');

0 commit comments

Comments
 (0)