Build com_dotnet shared by default #16300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The official Windows builds and CI are doing this for ages, so it appears to be overdue to finally switch the actual default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official Windows builds and CI are doing this for ages, so it appears to be overdue to finally switch the actual default.
Apparently, com_dotnet had been statically build for early PHP releases (makes some sense, because it could have been considered an integral part of PHP on Windows). However, as of PHP 5.5.0, com_dotnet had been built as shared extension, without changing the default in config.w32 (makes also sense to not break custom builds). That probably should have been changed in the next major PHP version, but obviously hasn't. Thus I'm suggesting to change it now (even if PHP next will be PHP 8.5), because I don't see any point in having a de-facto default which is different from the actual default. Custom builds with a static com_dotnet are still possible by passing
--enable-com-dotnet=yes.