Skip to content

Add missing descriptors for SmallFloatType and EnumType #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.0.x
Choose a base branch
from
Open

Add missing descriptors for SmallFloatType and EnumType #656

wants to merge 1 commit into from

Conversation

janedbal
Copy link
Contributor

@janedbal janedbal force-pushed the smallfloat-descriptor branch from 2082cc3 to 2e8b2b6 Compare April 24, 2025 14:03
janedbal
janedbal commented Apr 24, 2025
View reviewed changes
phpstan-baseline-dbal-4.neon
path: src/Type/Doctrine/Descriptors/SmallFloatType.php

-
message: '#^Class Doctrine\\DBAL\\Types\\EnumType not found\.$#'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first, I tried adding new doctrine versions to composer.json, but it would require bigger effort to adjust this repo to support those everywhere, so I just referenced those not-yet-existing classes.

ondrejmirtes
ondrejmirtes requested changes Apr 24, 2025
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • tests describing what this actually fixes would be nice

src/Type/Doctrine/Descriptors/SmallFloatType.php

namespace PHPStan\Type\Doctrine\Descriptors;

class SmallFloatType extends FloatType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No inheritance please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janedbal @ondrejmirtes