Skip to content

feat: attempt at versioning in docs #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: attempt at versioning in docs #37

wants to merge 4 commits into from

Conversation

@mirzakopic
Copy link
Contributor

@mirzakopic mirzakopic commented Oct 29, 2025

image

look at how-to-deploy/how-to.md for more details.

@github-actions
Copy link

github-actions bot commented Oct 29, 2025 •
edited
Loading

PR Preview Action v1.6.2

🚀 View preview at
https://platform-mesh.github.io/pr-preview/pr-37/

Built to branch gh-pages at 2025-10-29 15:50 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ntnn
Copy link
Member

ntnn commented Oct 29, 2025

Mhm the preview breaks, e.g. when I select a version it redirects to: https://platform-mesh.io/release-0.1/pr-preview/pr-37
Maybe the version should be disabled in the preview? It wouldn't make much sense there anyhow.

@mirzakopic
Copy link
Contributor Author

mirzakopic commented Oct 29, 2025

Mhm the preview breaks, e.g. when I select a version it redirects to: https://platform-mesh.io/release-0.1/pr-preview/pr-37 Maybe the version should be disabled in the preview? It wouldn't make much sense there anyhow.

I will have a look at it, you should also see the drop down as well. Let me check

@mirzakopic
Copy link
Contributor Author

mirzakopic commented Oct 29, 2025 •
edited
Loading

@ntnn I have disabled the version selector in the Pr-Preview. in 8791c42.

It is simply the easier option. 😄

@mirzakopic mirzakopic requested a review from ntnn October 29, 2025 15:46
mirzakopic
mirzakopic commented Oct 29, 2025
View reviewed changes
ntnn
ntnn approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@ntnn ntnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd maybe rename the how-to-deploy dir. Maybe just hack? Any scripts and other docs could also go in there.

@mirzakopic
Copy link
Contributor Author

mirzakopic commented Oct 30, 2025

Looks good. I'd maybe rename the how-to-deploy dir. Maybe just hack? Any scripts and other docs could also go in there.

Sounds good will do that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntnn ntnn ntnn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mirzakopic @ntnn