Add SplatViewer SOGS Compression #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
…ype definitions - Updated src type in AssetViewerProvider and SplatComponent to use Record<string, unknown> instead of SogsMeta. - Removed SogsMeta and related type definitions from splat-viewer.tsx to simplify the codebase.
- Updated the useAsset hook to replace the `props` parameter with `file`, aligning with PlayCanvas Asset properties. - Adjusted related hooks (useSplat, useTexture, useEnvAtlas, useModel) to reflect the new parameter naming. - Enhanced documentation to clarify the purpose of `file` and `data` parameters in asset loading.
- Renamed `isSogsMeta` to `isObject` for clarity in the SplatComponent. - Updated the logic for determining the source and options passed to the useSplat hook to enhance readability and maintainability.
…arity and functionality - Updated the useAsset hook to replace the `props` parameter with a more descriptive structure, enhancing the clarity of asset loading. - Adjusted related hooks (useSplat, useTexture, useEnvAtlas, useModel) to align with the new parameter naming and structure. - Enhanced documentation to clarify the purpose of the new props structure in asset loading. - Removed deprecated parameters and streamlined the fetchAsset utility to support the updated props format.
…ntation - Updated the useAsset hook to rename the `data` parameter to `props`, improving clarity in asset loading. - Adjusted the queryKey and fetchAsset calls to utilize the new `props` parameter. - Enhanced documentation to reflect the updated parameter naming and its purpose in asset loading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for SOGS compressed splats.
Example
API changes
The src type now accepts a Sogs Meta type. It's a non breaking change
The api makes no assumption about the actual data. it's entirely dependant on the engine implementation