-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Example 2 for Butterfly chart (version2) #4984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SimaRaha
wants to merge
13
commits into
plotly:doc-prod
Choose a base branch
from
SimaRaha:patch-3
base: doc-prod
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fbc94a2
Added plotly-universities-1.ipynb for visualization updates
SimaRaha f386c0b
butterfly with neutral column
rl-utility-man 911b993
Delete scratchwork file
rl-utility-man 40cd4c8
replaced hard coded data with a read_csv from github
rl-utility-man 70b7f49
improved the comments.
rl-utility-man 886078f
add python decorator
rl-utility-man d5e2284
corrected quotation mark type
rl-utility-man be52c35
replace an update_layout call with a go.figure() call
rl-utility-man 2140af6
moved yaxis title and legned layout to go.Figure()
rl-utility-man a14f4cb
introductory text edit.
rl-utility-man 8d0a2eb
attempted to manually merge the latest changes to doc-prod so the new…
rl-utility-man 3c4c096
removed the paste of the first diverging bar example
rl-utility-man 22c6434
edited introductory text to be order independent
rl-utility-man File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
butterfly with neutral column
- Loading branch information
commit f386c0baeaa1cf40bed3bad4158254b69de41bbf
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to put more of the layout and data in the go.Figure object. I think
update_layout
and other can be a bit more challenging to understand for a user.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! I moved one of the two update_layout calls into go.figure and also moved the update_legend there and the update_yaxes call there. If you do not like those, they're in atomic commits and can be rolled back. I do not see a clarifying way to eliminate the other update_layout call -- which sets up the secondary x axis and contains some variables not defined when we issue the fig = go.Figure() command. If it would be clearer to issue an update_layout that sets up both xaxis1 and xaxis2 in one call, that is straightforward. I welcome feedback about this and more specifics about other potential improvements to the structure and clarity of the code. Is there style guidance I should consult to understand this request better?