Skip to content

If IPython is merely installed, don't assume that it's actually used #5222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

If IPython is merely installed, don't assume that it's actually used #5222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions plotly/io/_renderers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,10 +542,11 @@ def show(fig, renderer=None, validate=True, **kwargs):
# orca not found
pass

# Check if we're running in ipython terminal
# Check if we're running in ipython terminal. Or, if we aren't
# running ipython at all.
ipython_info = ipython.get_ipython()
shell = ipython_info.__class__.__name__
if not default_renderer and (shell == "TerminalInteractiveShell"):
if not default_renderer and (shell in ("TerminalInteractiveShell", "NoneType")):
default_renderer = "browser"

# Check if we're running in a Jupyter notebook or JupyterLab
Expand Down