Skip to content

Fixed i18n Sync: Update Settings and SubmitSaveAllSettings Keys Across Locale Files #3510 #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ojuschugh1
Copy link

Fixes #3510

Changes:
I have now updated all the locale files to use the new keys and translations. Here's a summary of the changes made:
Replaced "SubmitSaveAllSettings" with "SaveAccountDetails" in all locale files
Updated "Settings" to "My Account" (or its translation) in the AccountView section of all locale files
The translations are now consistent across all languages and match the English version. The UI should now display the correct text in all supported languages.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@yugalkaushik
Copy link
Contributor

Thanks for the update!
Please make sure to read the Translation Guide. Just a quick note for future contributions: We recommend that only native or fluent speakers handle translations for that particular language to ensure accuracy.

@ojuschugh1
Copy link
Author

Thanks for the update @yugalkaushik , I will remember it for future !

@raclim
Copy link
Collaborator

raclim commented Jun 10, 2025

Yes, as @yugalkaushik noted, we would like to only accept translations that have been submitted by native or fluent speakers. Would you be able to update this pull request so that it only contains the languages that you speak natively?

@ojuschugh1
Copy link
Author

Hi @raclim sure I will change for Hindi as it is my native language after english

@raclim
Copy link
Collaborator

raclim commented Jun 10, 2025

Awesome, thanks so much for making this adjustment @ojuschugh1! Please feel free to note in the original issue that you've addressed the Hindi translation! If you'd like, you can also point out the other missing translations that still need to be addressed!

@ojuschugh1
Copy link
Author

Refer this PR #3523

@ojuschugh1 ojuschugh1 closed this Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n Sync: Update Settings and SubmitSaveAllSettings Keys Across Locale Files
3 participants