Add a collector for `pg_buffercache_summary`. #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

SuperQ merged 7 commits into prometheus-community:master from Snowflake-Labs:bufcache

Jun 19, 2025

Contributor

sfc-gh-pnuttall commented Jun 3, 2025 •

edited by SuperQ

Loading

Add a collector for pg_buffercache_summary()
Requires PostgreSQL >= 16.


          Add a collector for pg_buffercache.

2abb5c9

We use this code in production in a internal fork. We would like to
push it upstream. Default it to off, because it requires an extension to
be loaded.

Signed-off-by: Peter Nuttall <[email protected]>

SuperQ reviewed

View reviewed changes

collector/pg_buffercache.go Outdated Show resolved Hide resolved


          Update collector/pg_buffercache.go

Co-authored-by: Ben Kochie <[email protected]>
Signed-off-by: Peter Nuttall <[email protected]>

SuperQ reviewed

View reviewed changes

collector/pg_buffercache.go Outdated Show resolved Hide resolved

sfc-gh-pnuttall added 2 commits

June 18, 2025 16:18


          Rename s/pg_buffercache/pg_buffercache_summary/.

64f002f

Signed-off-by: Peter Nuttall <[email protected]>


          Merge branch 'bufcache' of github.com:Snowflake-Labs/postgres_exporte…

93a7548

…r into bufcache

Signed-off-by: Peter Nuttall <[email protected]>

SuperQ reviewed

View reviewed changes

collector/pg_buffercache_summary.go Outdated Show resolved Hide resolved

SuperQ reviewed

View reviewed changes

collector/pg_buffercache_summary.go Outdated Show resolved Hide resolved

sfc-gh-pnuttall and others added 2 commits

June 18, 2025 18:14


          Update collector/pg_buffercache_summary.go

aa004f6

Co-authored-by: Ben Kochie <[email protected]>
Signed-off-by: Peter Nuttall <[email protected]>


          Move gaugeInt32 into collector.go.

6e53796

Signed-off-by: Peter Nuttall <[email protected]>

SuperQ reviewed

View reviewed changes

collector/pg_buffercache_summary_test.go Outdated Show resolved Hide resolved


          copyright

62bcb12

Signed-off-by: Peter Nuttall <[email protected]>

SuperQ approved these changes

View reviewed changes

Contributor

SuperQ left a comment

I'm fine with the helper as-is.

I have a couple ideas on adding a type handling wrapper around prometheus.NewDesc() that would help with the boilerplate null value checks.

SuperQ changed the title ~~Add a collector for pg_buffercache.~~ Add a collector for pg_buffercache_summary.

SuperQ merged commit d8ba628 into prometheus-community:master

11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet