Update Sui how-to guide with corrected code and IDs #698
+115
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The assertion in the Move contract was incorrect. 2. Update the testnet pyth state id in the CLI example. 3. The TS code was deprecated. Used the latest @mysten/sui instead. 4. Added explanatory comments.
|
@Tzal3x is attempting to deploy a commit to the Pyth Network Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @aditya520 , mind taking a look? |
|
Hi, kind reminder regarding this PR as it would be beneficial for the community. @aditya520 |
|
My bad. I will review it this week. |
darunrs
approved these changes
Jun 18, 2025
| // Extract the price, decimal, and timestamp from the price struct and use them. | ||
| let decimal_i64 = price::get_expo(&price_struct); | ||
| let price_i64 = price::get_price(&price_struct); | ||
| let timestamp_sec = price::get_timestamp(&price_struct); |
There was a problem hiding this comment.
nit: the function returns an I64 but nothing gets returned. Granted this is demonstration code but it'd be nice if it is something that can be copied and built with no change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the Sui tutorial is not working at all. Several issues: an incorrect Move contract and the use of a deprecated Sui Typescript library. Plus incorrect use of state ids.
This PR fixes those issues by making the following changes:
@mysten/suiinstead.Type of Change
Areas Affected
https://docs.pyth.network/price-feeds/use-real-time-data/sui
Checklist
pre-commit run --all-filesto check for linting errorsRelated Issues
Closes #
Additional Notes
Contributor Information