Skip to content

React-native bigint64 deserialization problem - refactoring/bigint64le #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

React-native bigint64 deserialization problem - refactoring/bigint64le #16

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
89928fb
React-native compatible big int deserialization
Admdebian Nov 29, 2021
5377e05
byte lenght bugfix
Admdebian Nov 29, 2021
a0f706d
Custom deserialization function for 8 bit buffers
Admdebian Nov 29, 2021
372cef9
lint and comment fix
Admdebian Nov 29, 2021
78b1e2b
number to bigint refactoring and small changes
Admdebian Nov 29, 2021
3e53b69
fix test failure: The number NaN cannot be converted to a BigInt
Admdebian Nov 29, 2021
0f9e287
Bugfix for long buffers
Admdebian Nov 29, 2021
a2dce11
Minimal changes to work with react-native
Admdebian Nov 29, 2021
e7374a8
Fix signed numbers without << operator
Admdebian Nov 29, 2021
1eba710
Problem with biginteger and BigInteger
Admdebian Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix signed numbers without << operator
  • Loading branch information
@Admdebian
Admdebian committed Nov 29, 2021
commit e7374a8f007f23e49162f22757ca11d743bec2d8
20 changes: 10 additions & 10 deletions src/readBig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,16 @@ function boundsError(value: number, length: number) {

// https://github.com/nodejs/node/blob/v14.17.0/lib/internal/buffer.js#L129-L145
export function readBigInt64LE(buffer: Buffer, offset = 0): bigint {
validateNumber(offset, 'offset')
const first = buffer[offset]
const last = buffer[offset + 7]
if (first === undefined || last === undefined) boundsError(offset, buffer.length - 8)
// tslint:disable-next-line:no-bitwise
const val = buffer[offset + 4] + buffer[offset + 5] * 2 ** 8 + buffer[offset + 6] * 2 ** 16 + (last * 2 ** 24) // Overflow
return (
(BigInt(val) * BigInt(2 ** 32)) + // tslint:disable-line:no-bitwise
BigInt(first + buffer[++offset] * 2 ** 8 + buffer[++offset] * 2 ** 16 + buffer[++offset] * 2 ** 24)
)
const resultUnsigned = readBigUInt64LE(buffer, offset)

const FFFFFFFFFFFFFFFF = BigInt(2**64 - 1);

if(buffer.length >= 8) {
if(buffer[7] >= 128)
return resultUnsigned - FFFFFFFFFFFFFFFF;
}

return resultUnsigned
}

// https://github.com/nodejs/node/blob/v14.17.0/lib/internal/buffer.js#L89-L107
Expand Down