-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
add internal asyncio implementation docs #135469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest this looks more like a thorough description of and rationale for the changes to support free-threading (and asyncio pstree
), than a description of asyncio internals. As such, I think it belongs somewhere but I'm not sure if InternalDocs is the right place. Maybe @iritkatriel has an opinion?)
Nit: Call me old-fashioned, but could you please break lines longer than 100 or 120 characters? (Preferably at commas, semicolons, colons and periods.)
Co-authored-by: Guido van Rossum <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I now follow the reasoning. LGTM!
This documents the work I did in 3.14 for better performance in both free-threading and gil builds and scaling asyncio in free-threading.