-
-
Notifications
You must be signed in to change notification settings - Fork 3k
[mypyc] Merge generator and environment classes in simple cases #19207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhance
approved these changes
Jun 2, 2025
Here's IR for the
Here's the IR after this PR, when merging is enabled:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypyc used to always compile a generator or an async def into two classes: a generator and an environment. Now we combine these two classes in simple cases where it's clearly okay to do it (when there is no nesting). We could probably extend it to other use cases as well, including some nested functions, but this is a start.
This improves performance by reducing the number of instances that will be allocated. Also access to the environment object is slightly faster, though this is probably relatively minor. This helps calling async defs in particular, since they typically yield only a single value, so the objects are not used much until they are freed. Also generators that only yield a small number of values benefit from this.
The existing test cases provide decent test coverage. I previously added some additional tests in anticipation of this change.
This also reduces the amount of C code generated when compiling async defs and generators.
This speeds up this micro-benchmark on the order of 20%: