Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

"babel-browser has been removed." #116

Closed
wants to merge 2 commits into from
Closed

Conversation

C-F-K
Copy link

@C-F-K C-F-K commented Jan 19, 2016

See here:

https://babeljs.io/docs/usage/browser/

This breaks the tutorial, so I messed around with it until it worked again. My solution isn't particularly elegant, though.

For some reason, babel-standalone also throws a fit about the call to render being on multiple lines. (Alternatively I could be missing something obvious.) No it doesn't anymore, and I still don't know why it did. ¯_(ツ)_/¯

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@zpao
Copy link
Member

zpao commented Jan 24, 2016

Thanks, but I'm going to leave this as is for the time being. We'll replace babel-browser at some point but for now we're using the one from the CDN which still works and we'd like to keep the focus on React, not needing to think about another inline script (which we then also need to explain in the tutorial text)

@zpao zpao closed this Jan 24, 2016
@C-F-K
Copy link
Author

C-F-K commented Jan 24, 2016

That's your prerogative. Points of interest, though:

  • I wouldn't have needed to make these changes if the one from the CDN had worked for me. I may or may not be a representative sample of people following the tutorial, but in any case "it works" as a blanket statement is false.
  • you're right, the focus should be on React, which is why people following the tutorial should be able to write their components and just have them work. A statement to the effect of "don't worry about the rest of this code" is all you'd need, if anything (since "simply" in the comment in the otherwise empty <script> tag already more or less implies that).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants