[REACTOS] Change manifest architecture from X86 to * #7930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkreuzer
requested review from
binarymaster,
learn-more,
HBelusca,
katahiromz,
cbialorucki,
GeoB99 and
whindsaks
HBelusca
approved these changes
Apr 24, 2025
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | |||
| <assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0"> | |||
| <assemblyIdentity type="win32" name="redirtest2" version="0.2.2.2" processorArchitecture="x86" /> | |||
| <assemblyIdentity type="win32" name="redirtest2" version="0.2.2.2" processorArchitecture="*" /> | |||
| <file name="kernel32test_versioned.dll"/> | |||
| </assembly> | |||
|
|
|||
whindsaks
approved these changes
Apr 24, 2025
binarymaster
approved these changes
Apr 24, 2025
learn-more
approved these changes
Apr 24, 2025
katahiromz
approved these changes
Apr 25, 2025
| @@ -1,5 +1,5 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | |||
| <assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0"> | |||
| <assemblyIdentity type="win32" name="Microsoft.VC80.ATL" version="8.0.50727.4053" processorArchitecture="" publicKeyToken="1fc8b3b9a1e18e3b"/> | |||
| <assemblyIdentity type="win32" name="Microsoft.VC80.ATL" version="8.0.50727.4053" processorArchitecture="*" publicKeyToken="1fc8b3b9a1e18e3b"/> | |||
There was a problem hiding this comment.
There are 5 other occurrences (2 gdiplus and 3 msxml), in case they would apply too:
https://git.reactos.org/?p=reactos.git&a=search&h=HEAD&st=grep&s=processorArchitecture%3D%22%22
cbialorucki
approved these changes
Apr 27, 2025
tkreuzer
force-pushed
the
amd64/manifest-arch
branch
from
2e370bb to
bc2d7e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Change manifest architecture from X86 to *
Testbot runs (Filled in by Devs)