[E1000] Implement OID_GEN_PHYSICAL_MEDIUM

[tkreuzer]

Purpose

Implement OID_GEN_PHYSICAL_MEDIUM in e1000 driver to silence annoying debug spam on VBox.

Testbot runs (Filled in by Devs)

• KVM x86: https://reactos.org/testman/compare.php?ids=102104,102107
• KVM x64: https://reactos.org/testman/compare.php?ids=102088,102101

[disean]

This OID is optional for NDIS miniport drivers, I believe the debug print should be muted instead.

reactos/drivers/network/dd/e1000/info.c

Line 275 in 8775cab

NDIS_DbgPrint(MAX_TRACE, ("Query OID 0x%x(%s): Completed with status 0x%x (%d, %d)\n",

+if (Oid != OID_GEN_PHYSICAL_MEDIUM)
+{
    NDIS_DbgPrint(MAX_TRACE, ("Query OID 0x%x(%s): Completed with status 0x%x (%d, %d)\n",
                              Oid, Oid2Str(Oid), status, *BytesWritten, *BytesNeeded));
+}

[tkreuzer]

This OID is optional for NDIS miniport drivers, I believe the debug print should be muted instead.

@disean What's wrong with implementing an optional OID?

[disean]

What's wrong with implementing an optional OID?

Because it's meant more for Wi-Fi drivers. You're fixing the debug spam in a Vbox-specific environment setup, but not the root cause of it.

[tkreuzer]

Because it's meant more for Wi-Fi drivers.

It's meant for any kind of driver, because that is why the enum contains all those values.

You're fixing the debug spam in a Vbox-specific environment setup, but not the root cause of it.

Huh? The root cause of that debug print is the debug print due to it being unimplemented. If with "root cause" you mean the calling code should first use OID_GEN_SUPPORTED_LIST or cache the status or whatever: feel free to implement that, but that code is WIP and I will not touch it.