Skip to content

feat(react-router): stabilize useRevalidator's revalidate #13511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MichaelDeBoey
Copy link
Member

Copy link

changeset-bot bot commented Apr 30, 2025

⚠️ No Changeset found

Latest commit: 3da3292

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 self-assigned this Apr 30, 2025
@brophdawg11
Copy link
Contributor

Looking good! Just minor comments and then we just need a changeset and this should be able to be merged. If you have time to look into a unit test in use-revalidator-test.tsx that would be great but I can try to get one asded to if you're tight on time 🙌

@MichaelDeBoey MichaelDeBoey force-pushed the stabilize-useRevalidators-revalidate branch from bde3b63 to 3da3292 Compare May 2, 2025 21:48
@MichaelDeBoey
Copy link
Member Author

@brophdawg11 If you would have some time to add the extra tests, that would be awesome! 🙏

@brophdawg11 brophdawg11 changed the base branch from dev to brophdawg11/stabilize-revalidate May 6, 2025 14:46
@brophdawg11 brophdawg11 merged commit 930a3dd into remix-run:brophdawg11/stabilize-revalidate May 6, 2025
5 checks passed
@brophdawg11
Copy link
Contributor

#13542

@MichaelDeBoey MichaelDeBoey deleted the stabilize-useRevalidators-revalidate branch May 6, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants