Skip to content

Initial dictionary page #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025
Merged

Initial dictionary page #1006

merged 3 commits into from
May 5, 2025

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented May 3, 2025

Feedback is welcome here!
Not sure about the page location.
Feels right to me, but open to discuss it.

Copy link

vercel bot commented May 3, 2025

@nojaf is attempting to deploy a commit to the ReScript Association Team on Vercel.

A member of the Team first needs to authorize it.

@nojaf nojaf requested a review from fhammerschmidt May 3, 2025 07:27
Copy link
Member

@fhammerschmidt fhammerschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
Some small requests, and a large one:
Would you also add the corresponding syntax lookup page?

@zth
Copy link
Collaborator

zth commented May 3, 2025

Closes #920

@zth
Copy link
Collaborator

zth commented May 5, 2025

@fhammerschmidt ready for another review.

@zth zth requested a review from fhammerschmidt May 5, 2025 08:22
Copy link
Member

@fhammerschmidt fhammerschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing stuff!

@fhammerschmidt fhammerschmidt merged commit 341de45 into rescript-lang:master May 5, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants