Skip to content

remove deadcode related to nav dropdown #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025

Conversation

jderochervlk
Copy link
Collaborator

@jderochervlk jderochervlk commented May 5, 2025

Cleans up some code that is no longer needed and solves a bug that causes the mobile nav to disappear when scrolling on the doc page.

Copy link

vercel bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rescript-lang.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2025 3:47pm

Copy link

cloudflare-workers-and-pages bot commented May 5, 2025

Deploying rescript-lang-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8c3ae89
Status: ✅  Deploy successful!
Preview URL: https://fe8ad4a1.rescript-lang.pages.dev
Branch Preview URL: https://vlk-cleanup-dropdown-code.rescript-lang.pages.dev

View logs

@jderochervlk jderochervlk marked this pull request as ready for review May 5, 2025 16:00
@fhammerschmidt fhammerschmidt merged commit f881fde into master May 5, 2025
4 checks passed
@cometkim
Copy link
Member

cometkim commented May 5, 2025

Can you please let me know what problem what we had because of collapsable navbar?

The thick persistent header is really annoying to me because I often read on mobile 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants