Skip to content

Comments removed in JSX expression #7416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shulhi opened this issue Feb 1, 2025 · 0 comments · Fixed by #7424
Closed

Comments removed in JSX expression #7416

shulhi opened this issue Feb 1, 2025 · 0 comments · Fixed by #7424
Assignees
@shulhi
Labels
bug
Milestone
v12

Comments

@shulhi
Copy link
Member

shulhi commented Feb 1, 2025

When comments are outside of braces, it gets removed in certain cases.

https://rescript-lang.org/try?version=v11.1.4&module=esmodule&code=DYUwLgBAHhC8EB4AmBLAbgPgFAQgejwgGMB7AWzJADswcIBvO3USAQzggCIALEYYEpywBIAEohWRMADoAzmABOKKgHMAFKwCUuXHQC+WBHlSYgA
@shulhi shulhi mentioned this issue Feb 1, 2025
Merged
@cknitt cknitt transferred this issue from rescript-lang/rescript-react May 4, 2025
@cknitt cknitt added this to the v12 milestone May 4, 2025
@cknitt cknitt added the bug label May 5, 2025
@shulhi shulhi mentioned this issue May 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shulhi shulhi

Labels
bug
Projects
None yet
Milestone
v12
Development

Successfully merging a pull request may close this issue.

Fix comments removed in JSX shulhi/rescript-compiler
2 participants
@cknitt @shulhi