Skip to content

Fix comments removed in JSX #7424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2025
Merged

Fix comments removed in JSX #7424

merged 3 commits into from
May 5, 2025

Conversation

shulhi
Copy link
Member

@shulhi shulhi commented May 5, 2025 •
edited
Loading

Fix #7416

@shulhi shulhi marked this pull request as draft May 5, 2025 09:39
@shulhi shulhi force-pushed the fix/jsx-comment-with-braces branch from b266802 to 62b2d72 Compare May 5, 2025 11:17
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 5, 2025 •
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7424

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7424

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7424

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7424

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7424

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7424

commit: 18a4441

@shulhi shulhi force-pushed the fix/jsx-comment-with-braces branch from 62b2d72 to 4782d78 Compare May 5, 2025 12:13
@shulhi shulhi marked this pull request as ready for review May 5, 2025 12:39
@zth
Copy link
Collaborator

zth commented May 5, 2025

@shulhi we miss you at the retreat!

nojaf
nojaf approved these changes May 5, 2025
View reviewed changes
Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@shulhi shulhi merged commit fb3a6bd into rescript-lang:master May 5, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comments removed in JSX expression
3 participants
@shulhi @zth @nojaf