Error message: Suggest module in place of value where it makes sense #7384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
reviewed
Apr 8, 2025
| match as_module with | ||
| | None -> () | ||
| | Some module_path -> | ||
| Format.fprintf ppf "@,@[<v 2>@,@[%s to use the module @{<info>%a@}?@]@]" |
There was a problem hiding this comment.
What is "@,@[<v 2>@,@[%s here exactly?
There was a problem hiding this comment.
Yeah, I meant more specially the @,@[< incantation.
There was a problem hiding this comment.
Damn, just asked an LLM, this is some gourmet camel you are cooking.
| a lowercase identifier in JS but a module in ReScript. | ||
|
|
||
| 'Console' is a typical example, where JS is `console.log` and ReScript is `Console.log`. *) | ||
| (* TODO(codemods) Add codemod for refering to the module instead. *) |
There was a problem hiding this comment.
Is the todo for a code action here?
There was a problem hiding this comment.
Yeah, this is one of those places we can add a code action for when we get that setup.
nojaf
approved these changes
Apr 8, 2025
cknitt
reviewed
Apr 14, 2025
| const fixtures = readdirSync("fixtures").filter( | ||
| fileName => path.extname(fileName) === ".res", | ||
| const fixtures = readdirSync(path.join(import.meta.dirname, "fixtures")).filter( | ||
| (fileName) => path.extname(fileName) === ".res" |
There was a problem hiding this comment.
Why did the formatting change here?
There was a problem hiding this comment.
You mean the parenthesis on (fileName)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some subtle differences between how certain common things are called in ReScript vs in JS. One example is logging to the console:
This difference (value vs module) can be subtle and not easily discoverable. So, this PR does a small addition to the "missing value" error message, and suggests the module version of the identifier if it exists in scope. This is intended to give a small hint for what you might be looking for, instead of just telling you to "go fish".