Skip to content

Use more Yarn workspaces in scripts #7391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 16, 2025
Merged

Use more Yarn workspaces in scripts #7391

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
db69a87
Add packages to workspaces
cometkim Apr 11, 2025
f8f368b
add comment about yarn
cometkim Apr 14, 2025
bc5ba8c
use Yarn workspace instead npm link
cometkim Apr 14, 2025
c9b18e1
use an isolated directory for installation test
cometkim Apr 14, 2025
7d51d64
remove unused script
cometkim Apr 14, 2025
72b7dd5
exclude installation test template from workspaces
cometkim Apr 14, 2025
2f71c2d
compose playground settings into a single workspace
cometkim Apr 14, 2025
b537be4
allow overwrite binaries
cometkim Apr 14, 2025
7666f70
don't rebuild entriely on building playground
cometkim Apr 16, 2025
55bdc1b
revert unintended change
cometkim Apr 16, 2025
005d2e8
fix installation test
cometkim Apr 16, 2025
80f8ff4
fix upload script
cometkim Apr 16, 2025
6a99b66
use better variable name
cometkim Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert unintended change
  • Loading branch information
@cometkim
cometkim committed Apr 16, 2025
commit 55bdc1ba8221c8f191468013e8c355a6906c9293
2 changes: 1 addition & 1 deletion packages/playground/scripts/upload_bundle.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ SCRIPT_PATH=${BASH_SOURCE[0]}
SCRIPT_DIR=$(dirname "$(dirname "$current_script_path")")

# Get the actual version from the compiled playground bundle
VERSION=$(cd $SCRIPT_DIR; node -e 'require("/compiler.js"); console.log(rescript_compiler.make().rescript.version)')
VERSION=$(cd $SCRIPT_DIR; node -e 'require("./compiler.js"); console.log(rescript_compiler.make().rescript.version)')

if [ -z "${KEYCDN_USER}" ]; then
echo "KEYCDN_USER environment variable not set. Make sure to set the environment accordingly."
Expand Down
Loading