Skip to content

add assertEqual to docstrings #7417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2025
Merged

add assertEqual to docstrings #7417

merged 2 commits into from
May 4, 2025

Conversation

bloodyowl
Copy link
Collaborator

@bloodyowl bloodyowl commented May 4, 2025 •
edited
Loading

adds assertEqual to missing stdlib modules:

  • Belt
    • Array
    • Float
    • HashMap
    • List
    • Map
    • MapDict
    • MutableSet
    • Option
    • Range
    • Result
    • SetDict
    • SortArray
  • Stdlib
    • SortArray
    • List
    • Math

closes #7374

@bloodyowl bloodyowl force-pushed the assert-equal-docstrings branch from 677381a to 580a75f Compare May 4, 2025 14:58
@bloodyowl bloodyowl requested a review from cknitt May 4, 2025 15:01
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 4, 2025 •
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7417

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7417

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7417

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7417

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7417

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7417

commit: f485ee9

cknitt
cknitt reviewed May 4, 2025
View reviewed changes
cknitt
cknitt approved these changes May 4, 2025
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🎉

@bloodyowl bloodyowl merged commit 484fa0d into master May 4, 2025
21 checks passed
@bloodyowl bloodyowl deleted the assert-equal-docstrings branch May 4, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stdlib: use assertEqual in all doc strings
2 participants
@bloodyowl @cknitt