Fix leaky tests #9212
Open
Fix leaky tests #9212
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- While working on ruby#9210, I found those leaky tests which break the test suite. They remove Bundler constants without setting them back. The reason it's not a problem on master is because there are no tests that install gems in the same process (all tests shell out to `bundle install`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Some tests are leaky and it makes the work I'm doing in #9210 not possible.
What is your fix for the problem, implemented in this PR?
While working on #9210, I found those leaky tests which break the test suite. They remove Bundler constants without setting them back.
rubygems/bundler/lib/bundler/plugin/events.rb
Lines 17 to 20 in ca8ac9f
The reason it's not a problem on master is because there are no tests that install gems in the same process (all tests shell out to
bundle install).In #9210 I install gems using the Bundler API instead of shelling out (its much faster), and this also needs to be fixed if we want to achieve #9195
Make sure the following tasks are checked