Update lints #4473
Merged
Update lints #4473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
added
stable-nominated
We check with `-Dwarnings` in CI, so these still get checked. This change serves to prevent failures to compile downstream if the lint expectations are not met on untested targets.
tgross35
force-pushed
the
update-lints
branch
4 times, most recently
from
6b0016d to
c1b4b20
Compare
tgross35
force-pushed
the
update-lints
branch
2 times, most recently
from
f726a7d to
64a03e3
Compare
As discussed in [1], some changes to dead code warnings caused a lot of code to be inaccurately reported as dead in `libc`. The change was reverted and improved since then, so we no longer need to skip this check. Includes some changes to make things pass with the lint. [1]: rust-lang#3740
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 3, 2025
We check with `-Dwarnings` in CI, so these still get checked. This change serves to prevent failures to compile downstream if the lint expectations are not met on untested targets. (backport <rust-lang#4473>) (cherry picked from commit 260e357)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 3, 2025
(backport <rust-lang#4473>) (cherry picked from commit 0b6aa1b)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 3, 2025
As discussed in [1], some changes to dead code warnings caused a lot of code to be inaccurately reported as dead in `libc`. The change was reverted and improved since then, so we no longer need to skip this check. Includes some changes to make things pass with the lint. [1]: rust-lang#3740 (backport <rust-lang#4473>) (cherry picked from commit 77a21a8)
Merged
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 3, 2025
We check with `-Dwarnings` in CI, so these still get checked. This change serves to prevent failures to compile downstream if the lint expectations are not met on untested targets. (backport <rust-lang#4473>) (cherry picked from commit 260e357)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 3, 2025
(backport <rust-lang#4473>) (cherry picked from commit 0b6aa1b)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 3, 2025
As discussed in [1], some changes to dead code warnings caused a lot of code to be inaccurately reported as dead in `libc`. The change was reverted and improved since then, so we no longer need to skip this check. Includes some changes to make things pass with the lint. [1]: rust-lang#3740 (backport <rust-lang#4473>) (cherry picked from commit 77a21a8)
tgross35
added
stable-applied
DorianNiemiecSVRJS
pushed a commit
to DorianNiemiecSVRJS/rust-libc
that referenced
this pull request
Jun 21, 2025
We check with `-Dwarnings` in CI, so these still get checked. This change serves to prevent failures to compile downstream if the lint expectations are not met on untested targets. (backport <rust-lang#4473>) (cherry picked from commit 260e357)
DorianNiemiecSVRJS
pushed a commit
to DorianNiemiecSVRJS/rust-libc
that referenced
this pull request
Jun 21, 2025
(backport <rust-lang#4473>) (cherry picked from commit 0b6aa1b)
DorianNiemiecSVRJS
pushed a commit
to DorianNiemiecSVRJS/rust-libc
that referenced
this pull request
Jun 21, 2025
As discussed in [1], some changes to dead code warnings caused a lot of code to be inaccurately reported as dead in `libc`. The change was reverted and improved since then, so we no longer need to skip this check. Includes some changes to make things pass with the lint. [1]: rust-lang#3740 (backport <rust-lang#4473>) (cherry picked from commit 77a21a8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lints: Warn rather than deny
We check with
-Dwarningsin CI, so these still get checked. Thischange serves to prevent failures to compile downstream if the lint
expectations are not met on untested targets.
lints: Remove
allow(dead_code)As discussed in 1, some changes to dead code warnings caused a lot of
code to be inaccurately reported as dead in
libc. The change wasreverted and improved since then, so we no longer need to skip this
check.
lints: Remove
allow(redundant_semicolons)