Skip to content

Improve HTMLCollection, add HTMLOptionsCollection and HTMLFormControlsCollection #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 17, 2021
Merged

Improve HTMLCollection, add HTMLOptionsCollection and HTMLFormControlsCollection #593

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3d1f149
Create HTMLOptionsCollection to improve ux when dealing with <select>…
ghostbuster91 Oct 11, 2021
1b07261
Rewrite HTMLOptionsCollection to extend HTMLCollection
ghostbuster91 Oct 13, 2021
dd4b4af
Parametrize HtmlCollection class with the type of the element
ghostbuster91 Oct 13, 2021
77f33b6
Add HTMLFormControlsCollection, RadioNodeList and remove upper-bound …
ghostbuster91 Oct 15, 2021
568172c
Remove upper-bound type constrain from HTMLCollection type aliases
ghostbuster91 Oct 16, 2021
ea0eb4f
Drop generic type from HTMLCollectionElement to restore bin-compat
ghostbuster91 Oct 16, 2021
00dccef
Regenerate api reports
ghostbuster91 Oct 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Drop generic type from HTMLCollectionElement to restore bin-compat 
Co-authored-by: Arman Bilge <[email protected]>
  • Loading branch information
@ghostbuster91 @armanbilge
ghostbuster91 and armanbilge authored Oct 16, 2021
commit ea0eb4faa57e5d226bc8e45069f562bd396cec5f
2 changes: 1 addition & 1 deletion src/main/scala/org/scalajs/dom/raw.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ object raw {
type HTMLCanvasElement = dom.HTMLCanvasElement

@deprecated("use dom.HTMLCollection instead", "2.0.0")
type HTMLCollectionElement[E] = dom.HTMLCollection[E]
type HTMLCollectionElement = dom.HTMLCollection[dom.Element]

@deprecated("use dom.HTMLDataListElement instead", "2.0.0")
type HTMLDataListElement = dom.HTMLDataListElement
Expand Down