Skip to content

Audio API changes #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
4f524b8
backup
yilinwei Jul 22, 2023
8b1d132
backup
yilinwei Jul 22, 2023
b44eaa8
backup
yilinwei Jul 22, 2023
2aaf2ed
Switch back to using traits for now.
yilinwei Sep 18, 2023
b91df37
typo.
yilinwei Sep 18, 2023
a4edff5
Switch encoding for mima.
yilinwei Sep 24, 2023
9887ce0
Check-in API report
yilinwei Sep 24, 2023
081534d
BlobEvent and MediaRecorder.
zainab-ali Oct 8, 2023
fca6713
Make sure `BlobEvent` is class.
yilinwei Oct 8, 2023
4dda4bf
`data` is required.
yilinwei Oct 8, 2023
a4cfb9a
Add `AudioWorkletNode` and associated options.
yilinwei Nov 15, 2023
0099ad3
Add `Worklet` and `AudioWorklet`.
yilinwei Nov 15, 2023
e8b3650
Fix signature
yilinwei Nov 15, 2023
1178935
Add `AudioParamDescriptor`.
yilinwei Nov 15, 2023
fdb9aad
Add `defaultValue` for `AudioParamDescriptor`.
yilinwei Nov 15, 2023
c067de2
Make sure to extend `js.Object`.
yilinwei Nov 15, 2023
ba8f619
Add `AudioWorkletGlobalScope`.
yilinwei Nov 15, 2023
3e32f25
`AudioWorkletNode` should not be abstract.
yilinwei Nov 16, 2023
42275a7
Make `ReadOnlyMapLike` extend `js.Iterable`.
yilinwei Nov 16, 2023
0e90800
`self` does not yet exist within the `Worklet` contexts.
yilinwei Nov 16, 2023
f860eaa
Correct `ReadOnlyMapLike` signature `forEach`.
yilinwei Nov 16, 2023
b548118
Add docs.
zainab-ali Dec 2, 2023
2d1f240
Add docs.
zainab-ali Dec 2, 2023
f7adab3
Doc improvements.
zainab-ali Dec 18, 2023
56d513b
Add js.native annotation to AudioParamAutomationRate.
zainab-ali Dec 18, 2023
6781565
More docs.
zainab-ali Dec 18, 2023
7d6eb4e
Add js.native annotation to AudioTimestamp.
zainab-ali Dec 18, 2023
d159170
Correct type of params for AudioWorkletProcessor.
zainab-ali Dec 18, 2023
3bac38d
WorkletOptions should extend js.Object.
zainab-ali Dec 18, 2023
e32a80c
Add MediaRecorder and options.
zainab-ali Dec 18, 2023
c221e2b
Correct scaladoc.
zainab-ali Dec 18, 2023
824092d
Api reports.
zainab-ali Dec 18, 2023
e637830
AudioWorkletGlobalScope should be an abstract class.
zainab-ali Dec 29, 2023
314c67b
AudioScheduledSourceNode should be an abstract class.
zainab-ali Dec 29, 2023
9923b6b
MediaElementAudioSourceNode mediaElement should be a def.
zainab-ali Dec 29, 2023
98af177
Regenerate api reports.
zainab-ali Dec 29, 2023
18a6f7d
Add docs for ReadOnlyMapLike.
zainab-ali Dec 29, 2023
df8e9cf
Reformat doc comments.
zainab-ali Jan 28, 2024
523266a
Remove redundant comment.
zainab-ali Jan 28, 2024
07dcf43
Remove channelCount, channelCountMode and channelInterpretation.
zainab-ali Jan 28, 2024
b3a694e
Refactor enums for Scala 3.
zainab-ali Jan 28, 2024
e305129
Regenerate API reports.
zainab-ali Jan 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add Worklet and AudioWorklet.
  • Loading branch information
yilinwei committed Nov 15, 2023
commit 0099ad3287625daef254f9eb68ffd7acc183c39f
15 changes: 15 additions & 0 deletions dom/src/main/scala/org/scalajs/dom/AudioWorklet.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
/** Documentation is thanks to Mozilla Contributors at https://developer.mozilla.org/en-US/docs/Web/API and available
* under the Creative Commons Attribution-ShareAlike v2.5 or later. http://creativecommons.org/licenses/by-sa/2.5/
*
* Everything else is under the MIT License http://opensource.org/licenses/MIT
*/

package org.scalajs.dom

import scala.scalajs.js
import scala.scalajs.js.annotation._

@JSGlobal
@js.native
abstract class AudioWorklet extends Worklet {
}
5 changes: 3 additions & 2 deletions dom/src/main/scala/org/scalajs/dom/AudioWorkletNode.scala
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import scala.scalajs.js.annotation._

@JSGlobal
@js.native
abstract class AudioWorkletNode(context: BaseAudioContext, name: String, options: AudioWorkletNodeOptions = js.native) extends AudioNode {
abstract class AudioWorkletNode(context: BaseAudioContext, name: String, options: AudioWorkletNodeOptions = js.native)
extends AudioNode {

def port: MessagePort
val port: MessagePort = js.native
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ trait AudioWorkletNodeOptions extends js.Any {

/** The value to initialize the [[AudioNode#numberOfInputs]] property. Defaults to 1. */
var numberOfInputs: js.UndefOr[Int] = js.undefined

/** The value to initialize the [[AudioNode#numberOfOutputs]] property. Defaults to 1. */
var numberOfOutputs: js.UndefOr[Int] = js.undefined
var outputChannelCount: js.UndefOr[js.Array[Int]] = js.undefined
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ abstract class AudioWorkletProcessor(options: AudioWorkletProcessorOptions) exte
/** The [[MessagePort]] object that is connecting the [[AudioWorkletProcessor]] and the associated
* [[AudioWorkletNode]].
*/
def port: MessagePort = js.native
val port: MessagePort = js.native

def process(inputs: js.typedarray.Float32Array, outputs: js.typedarray.Float32Array, parameters: js.Object): Boolean

Expand Down
5 changes: 5 additions & 0 deletions dom/src/main/scala/org/scalajs/dom/BaseAudioContext.scala
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ trait BaseAudioContext extends EventTarget {
*/
val sampleRate: Double = js.native

/** Returns an instance of [[AudioWorklet]] that can be used for adding [[AudioWorketProcessor]]-derived classes which
* implement custom audio processing.
*/
val audioWorklet: AudioWorklet = js.native

/** Returns the current state of the AudioContext. */
def state: String = js.native

Expand Down
16 changes: 16 additions & 0 deletions dom/src/main/scala/org/scalajs/dom/Worklet.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/** Documentation is thanks to Mozilla Contributors at https://developer.mozilla.org/en-US/docs/Web/API and available
* under the Creative Commons Attribution-ShareAlike v2.5 or later. http://creativecommons.org/licenses/by-sa/2.5/
*
* Everything else is under the MIT License http://opensource.org/licenses/MIT
*/

package org.scalajs.dom

import scala.scalajs.js
import scala.scalajs.js.annotation._

@JSGlobal
@js.native
abstract class Worklet extends js.Object {
def addModule(moduleURL: String, options: WorkletOptions = js.native): js.Promise[Unit] = js.native
}
13 changes: 13 additions & 0 deletions dom/src/main/scala/org/scalajs/dom/WorkletOptions.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/** Documentation is thanks to Mozilla Contributors at https://developer.mozilla.org/en-US/docs/Web/API and available
* under the Creative Commons Attribution-ShareAlike v2.5 or later. http://creativecommons.org/licenses/by-sa/2.5/
*
* Everything else is under the MIT License http://opensource.org/licenses/MIT
*/

package org.scalajs.dom

import scala.scalajs.js

trait WorkletOptions extends js.Any {
var credentials: js.UndefOr[RequestCredentials] = js.undefined
}