Skip to content

Respect export alias for default arg forwarder #21109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

Respect export alias for default arg forwarder #21109

merged 1 commit into from
Apr 24, 2025
+46 −12

Conversation

som-snytt
Copy link
Contributor

Fixes #19587

The default arg getter for the forwarder needs the export alias name.

@som-snytt som-snytt closed this Sep 15, 2024
@som-snytt som-snytt reopened this Apr 12, 2025
@som-snytt som-snytt marked this pull request as draft April 12, 2025 22:39
@som-snytt som-snytt force-pushed the issue/19587-rename-default-export branch from f72209f to 63e2da3 Compare April 14, 2025 14:43
@som-snytt som-snytt marked this pull request as ready for review April 14, 2025 14:46
@som-snytt
Copy link
Contributor Author

test_windows_fast fails with provisioning.

[info] Test dotty.tools.dotc.CompilationTests.pickling started

java compilation failed: 
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
Picked up _JAVA_OPTIONS: -Xmx8192m -XX:ReservedCodeCacheSize=512m -XX:MaxMetaspaceSize=1024m

@som-snytt som-snytt force-pushed the issue/19587-rename-default-export branch from 63e2da3 to 4db7df7 Compare April 17, 2025 17:09
@Gedochao Gedochao requested review from sjrd and odersky April 24, 2025 09:13
odersky
odersky approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@odersky odersky merged commit 82269f7 into scala:main Apr 24, 2025
29 checks passed
@som-snytt som-snytt deleted the issue/19587-rename-default-export branch April 24, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

@sjrd sjrd Awaiting requested review from sjrd

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exporting a method with a different name drops the default parameters
2 participants
@som-snytt @odersky