Skip to content

feature: combineInOrderAsync #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 8, 2025
Merged

feature: combineInOrderAsync #35

merged 18 commits into from
Apr 8, 2025

Conversation

GregOnNet
Copy link
Contributor

@GregOnNet GregOnNet commented Mar 18, 2025 •
edited
Loading

closes #36

GregOnNet added 18 commits March 17, 2025 08:58
@GregOnNet
chore(vscode): accept automatic change made by vsCode
71f27ec 
maybe the previous setting is outdated
@GregOnNet
feat(combine): handle one given ResultAsync
5b8630d
@GregOnNet
feat(combineAsync): handle failing ResultAsync
a0fd2c1
@GregOnNet
test(combineAsync): ensure dictionary of ResultAsync is handled
ddfbc9f
@GregOnNet
ref(combine): cleanup ResultAsync creation
54b4e7b
@GregOnNet
ref(combine): remove unneeded catch for ResultAsync
8d3abc2
@GregOnNet
feat(combine): refine error messages
822826b
@GregOnNet
feat(combine): support Result<T>
d8268f4
@GregOnNet
ref(combine): reword generic types
e63a399
@GregOnNet
feat(combineAsync): add api entry point to Result<T>
bd6ce36
@GregOnNet
ref(combineAsync): go back to simple concatenation of errors
ba57995
@GregOnNet
test(combine): simplify all test cases
e88b136
@GregOnNet
ref(combine): simplify iteration over record
4972d4e
@GregOnNet
feat(combine): remove support for Promises
76a24e8 
- it technically works fine
- but Promise Error is not the same as a Failure
- so we need to guess the error message and we do not know the type of the error of the promise
- it is better to wrap the Promise in a ResultAsync first specifying a human readable failure
@GregOnNet
ref(combine): clean up type names
5ec993f
@GregOnNet
fix(combine): correct wrong import
c38640f
@GregOnNet
fix(docs): correct jsdoc
62ccfb0
@GregOnNet
feat(combineInOrder): adopt combineAsync and make Promises being exec…
f7f9e12 
…uted in order
@GregOnNet GregOnNet changed the title feature: combineInOrder feature: combineInOrderAsync Mar 18, 2025
@seangwright seangwright self-requested a review April 8, 2025 18:30
@seangwright seangwright merged commit 5567f43 into seangwright:main Apr 8, 2025
1 check passed
@seangwright seangwright mentioned this pull request Apr 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seangwright seangwright seangwright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: combineInOrderAsync
2 participants
@GregOnNet @seangwright