Skip to content

Commit cfe6011

Browse files
committed
In debug builds display resource ID in resource inspector
* This can save some breakpointing and looking up in maps when a resource is named (especially if it's not given a unique name).
1 parent ff08748 commit cfe6011

File tree

2 files changed

+25
-9
lines changed

2 files changed

+25
-9
lines changed

qrenderdoc/Windows/ResourceInspector.cpp

Lines changed: 24 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ ResourceInspector::ResourceInspector(ICaptureContext &ctx, QWidget *parent)
103103
{
104104
ui->setupUi(this);
105105

106-
ui->resourceName->setText(tr("No Resource Selected"));
106+
SetResourceNameDisplay(tr("No Resource Selected"));
107107

108108
ui->resetName->hide();
109109
ui->resourceNameEdit->hide();
@@ -273,7 +273,7 @@ void ResourceInspector::Inspect(ResourceId id)
273273
{
274274
ANALYTIC_SET(UIFeatures.ResourceInspect, true);
275275

276-
ui->resourceName->setText(m_Ctx.GetResourceName(id));
276+
SetResourceNameDisplay(m_Ctx.GetResourceName(id));
277277

278278
ui->relatedResources->beginUpdate();
279279
ui->relatedResources->clear();
@@ -330,7 +330,7 @@ void ResourceInspector::Inspect(ResourceId id)
330330
else
331331
{
332332
m_Resource = ResourceId();
333-
ui->resourceName->setText(tr("No Resource Selected"));
333+
SetResourceNameDisplay(tr("No Resource Selected"));
334334
}
335335

336336
ui->initChunks->setUpdatesEnabled(true);
@@ -348,12 +348,26 @@ void ResourceInspector::OnCaptureLoaded()
348348
m_ResourceCacheID = m_Ctx.ResourceNameCacheID();
349349
}
350350

351+
void ResourceInspector::SetResourceNameDisplay(const QString &name)
352+
{
353+
#if defined(RELEASE)
354+
ui->resourceName->setText(name);
355+
#else
356+
if(m_Resource != ResourceId())
357+
ui->resourceName->setText(name + QFormatStr(" (%1)").arg(ToQStr(m_Resource)));
358+
else
359+
ui->resourceName->setText(name);
360+
#endif
361+
}
362+
351363
void ResourceInspector::OnCaptureClosed()
352364
{
365+
m_Resource = ResourceId();
366+
353367
ui->renameResource->setEnabled(false);
354368
ui->resetName->hide();
355369

356-
ui->resourceName->setText(tr("No Resource Selected"));
370+
SetResourceNameDisplay(tr("No Resource Selected"));
357371

358372
ui->viewContents->hide();
359373

@@ -363,8 +377,6 @@ void ResourceInspector::OnCaptureClosed()
363377
ui->initChunks->clearInternalExpansions();
364378
ui->relatedResources->clear();
365379
ui->resourceUsage->clear();
366-
367-
m_Resource = ResourceId();
368380
}
369381

370382
void ResourceInspector::OnEventChanged(uint32_t eventId)
@@ -389,14 +401,17 @@ void ResourceInspector::on_renameResource_clicked()
389401
}
390402
else
391403
{
404+
QString name = ui->resourceNameEdit->text();
405+
392406
// apply the edit
393-
ui->resourceName->setText(ui->resourceNameEdit->text());
407+
SetResourceNameDisplay(name);
408+
394409
ui->resourceNameEdit->hide();
395410
ui->resourceName->show();
396411

397412
ui->resetName->show();
398413

399-
m_Ctx.SetResourceCustomName(m_Resource, ui->resourceName->text());
414+
m_Ctx.SetResourceCustomName(m_Resource, name);
400415
}
401416
}
402417

@@ -417,7 +432,7 @@ void ResourceInspector::on_resourceNameEdit_keyPress(QKeyEvent *event)
417432

418433
void ResourceInspector::on_resetName_clicked()
419434
{
420-
ui->resourceName->setText(m_Ctx.GetResourceName(m_Resource));
435+
SetResourceNameDisplay(m_Ctx.GetResourceName(m_Resource));
421436

422437
ui->resetName->hide();
423438

qrenderdoc/Windows/ResourceInspector.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ private slots:
7777

7878
private:
7979
void HighlightUsage();
80+
void SetResourceNameDisplay(const QString &name);
8081

8182
Ui::ResourceInspector *ui;
8283
ICaptureContext &m_Ctx;

0 commit comments

Comments
 (0)