Skip to content

Prevent @Bean method being public if it should not be #45891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Jun 12, 2025

Fix the violation that classes are exposed outside their defined visibility scope.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 12, 2025
Fix the violation that classes are exposed outside their defined visibility scope.

Signed-off-by: Yanming Zhou <[email protected]>
@wilkinsona
Copy link
Member

This is close to being part of #32883 although we want to go further and make all @Bean methods package-private. We're holding off on doing that at least until the restructuring work is complete to avoid lots of conflicts on merge or rebase. Unfortunately, I don't think we can use this PR as it'll either create lots of conflicts if we merge it now, or have to be almost completely redone once the restructuring has landed. Thanks anyway.

@wilkinsona wilkinsona closed this Jun 12, 2025
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants