Skip to content

OAuth2Login DSL should support post-processing AuthenticationProvider implementations #17176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025

Conversation

fkowal
Copy link
Contributor

@fkowal fkowal commented May 27, 2025

fix 6.4 -> 6.5 class cast issue / relax type constraint

@jzheaux
Copy link
Contributor

jzheaux commented Jun 10, 2025

Hi, @fkowal, thanks for the quick fix! Will you please add a test to OAuth2LoginConfigurerTests that would fail before your fix and now it passes?

@jzheaux jzheaux added type: bug A general bug in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 10, 2025
@fkowal
Copy link
Contributor Author

fkowal commented Jun 11, 2025

@jzheaux test added

@jzheaux jzheaux self-assigned this Jun 17, 2025
@jzheaux jzheaux changed the title fix: #17175 relax type constraint (6.4 -> 6.5) compatible OAuth2Login DSL should support post-processing AuthenticationProvider implementations Jun 17, 2025
@jzheaux jzheaux changed the base branch from main to 6.5.x June 20, 2025 19:42
@jzheaux jzheaux added this to the 6.5.2 milestone Jun 20, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Jun 20, 2025

Thanks, @fkowal! I added a small polish to the test; otherwise, we'll merge this once the build completes. 🎉

@jzheaux jzheaux merged commit 9f88ef8 into spring-projects:6.5.x Jun 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants