Skip to content

fix(pgx): Do not wrap nil error #3913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

kyleconroy
Copy link
Collaborator

@kyleconroy kyleconroy commented Apr 1, 2025

When wrapping errors, add a nil check before wrapping the error.

Fixes #3912

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🔧 golang labels Apr 1, 2025
@kyleconroy kyleconroy merged commit 74e63c2 into main Apr 1, 2025
8 checks passed
@kyleconroy kyleconroy deleted the 3912-wrap_errors-pgx-always-returns-non-nil-error branch April 1, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files. 🔧 golang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrap_errors: pgx always returns non-nil error.
1 participant