Joliet long filenames #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinstated the invoker plugin, but disabled it selectively for Mac because it really doesn't want to work on OS X, but does work fine on other platforms (Windows, Debian)
Revert the Java version to 1.5 as 1.7 seemed a bit restrictive. Specify the invoker version earlier.
…xceptions when shortening. Change the file name shortening code so the unit test passes.
Allow for the configuration of the maximum Joliet filename length. The standard is for 64 UCS2 characters, but other lengths seem also to be possible. See documentation from Microsoft: http://msdn.microsoft.com/en-us/library/ff469400.aspx See also http://cdrtools.sourceforge.net/private/man/cdrecord/mkisofs.8.html
First attempt to fail on filename truncation
|
Stephen Connolly » java-iso-tools #7 SUCCESS |
Allow tests to run on Windows.
|
Stephen Connolly » java-iso-tools #8 SUCCESS |
…nto joliet-long-filenames Conflicts: iso9660-maven-plugin/pom.xml
|
Stephen Connolly » java-iso-tools #11 SUCCESS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #12 including unit test.
I've gone further and added a configuration option to allow longer filenames than the standard 64 characters. While this breaks the standard, up to 110 characters is claimed to work.
I've also added an option to fail the creation of the ISO if filename truncation would occur. This would help if the output includes content such as a web page that includes links. Success with truncated filenames would result in broken links.