Skip to content

Commit 642d201

Browse files
authored
Update esp32-hal-i2c.c
1 parent 323e240 commit 642d201

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

cores/esp32/esp32-hal-i2c.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,8 @@ i2c_err_t i2cAttachSCL(i2c_t * i2c, int8_t scl)
175175
if(i2c == NULL){
176176
return I2C_ERROR_DEV;
177177
}
178-
// digitalWrite(scl, HIGH); // optional before
179-
pinMode(scl, OUTPUT_OPEN_DRAIN | PULLUP);
180-
digitalWrite(scl, HIGH); // tested
178+
digitalWrite(scl, HIGH);
179+
pinMode(scl, OPEN_DRAIN | PULLUP);
181180
pinMatrixOutAttach(scl, I2C_SCL_IDX(i2c->num), false, false);
182181
pinMatrixInAttach(scl, I2C_SCL_IDX(i2c->num), false);
183182
return I2C_ERROR_OK;
@@ -199,9 +198,8 @@ i2c_err_t i2cAttachSDA(i2c_t * i2c, int8_t sda)
199198
if(i2c == NULL){
200199
return I2C_ERROR_DEV;
201200
}
202-
// digitalWrite(sda, HIGH); // optional before
203-
pinMode(sda, OUTPUT_OPEN_DRAIN | PULLUP);
204-
digitalWrite(sda, HIGH); // tested
201+
digitalWrite(sda, HIGH);
202+
pinMode(sda, OPEN_DRAIN | PULLUP);
205203
pinMatrixOutAttach(sda, I2C_SDA_IDX(i2c->num), false, false);
206204
pinMatrixInAttach(sda, I2C_SDA_IDX(i2c->num), false);
207205
return I2C_ERROR_OK;

0 commit comments

Comments
 (0)