chore(qemu): ship the initialized data dir at a different location #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for not shipping it originally was to avoid any possibility of the server starting up off a datadir on ephemeral storage. The initdb process itself is decently heavy though. We can tread the middle ground between the two by shipping the datadir at a secondary location, which the server never gets configured to run off. This datadir can be moved to the appropriate place on persistent storage prior to server startup. The simpler operation of copying the files over should be faster than the initdb routine.
thebengeu
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for not shipping it originally was to avoid any possibility
of the server starting up off a datadir on ephemeral storage.
The initdb process itself is decently heavy though. We can tread the
middle ground between the two by shipping the datadir at a secondary
location, which the server never gets configured to run off. This
datadir can be moved to the appropriate place on persistent storage
prior to server startup. The simpler operation of copying the files
over should be faster than the initdb routine.