Skip to content

fix: improve partial evaluation #15781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Apr 18, 2025
Merged

fix: improve partial evaluation #15781

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
cbb08ad
init
Ocean-OS Apr 17, 2025
e6c9e34
remove console log
Ocean-OS Apr 17, 2025
6bb9757
Update packages/svelte/src/compiler/phases/scope.js
Rich-Harris Apr 17, 2025
3a9aa79
fix each indices
Rich-Harris Apr 17, 2025
db4538d
dedupe
Rich-Harris Apr 17, 2025
c63cf04
Update packages/svelte/src/compiler/phases/scope.js
Rich-Harris Apr 17, 2025
6844bc4
always break
Rich-Harris Apr 17, 2025
bc997c1
fix formatting
Rich-Harris Apr 17, 2025
9325dc1
Apply suggestions from code review
Rich-Harris Apr 17, 2025
e3f2642
compactify
Rich-Harris Apr 17, 2025
79099ce
compactify
Rich-Harris Apr 17, 2025
ed6c208
reuse values
Rich-Harris Apr 17, 2025
ed7f90c
add more globals, template literals, try functions and (some) member …
Ocean-OS Apr 18, 2025
b238896
remove console logs
Ocean-OS Apr 18, 2025
3d967b6
Merge branch 'main' into fix-non-state-source-wackiness
Ocean-OS Apr 18, 2025
966f3cc
remove function handling, tweak failing test
Ocean-OS Apr 18, 2025
bba8242
changeset
Ocean-OS Apr 18, 2025
4d920c6
try putting static stuff in the template
Ocean-OS Apr 18, 2025
968045f
nevermind
Ocean-OS Apr 18, 2025
ec04063
unused
Rich-Harris Apr 18, 2025
fbf5512
simplify
Rich-Harris Apr 18, 2025
8f6f077
Update packages/svelte/src/compiler/phases/3-transform/client/visitor…
Rich-Harris Apr 18, 2025
47851ca
YAGNI
Rich-Harris Apr 18, 2025
2aec7b7
simplify and fix (should use cooked, not raw)
Rich-Harris Apr 18, 2025
040edc3
unused
Rich-Harris Apr 18, 2025
0ef68b9
changeset
Rich-Harris Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
@Rich-Harris
Rich-Harris authored Apr 17, 2025
commit 9325dc117dfa80c9965ebb9b2027e5b433fd3877
28 changes: 2 additions & 26 deletions packages/svelte/src/compiler/phases/scope.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,20 +407,8 @@ class Evaluation {
const arg = scope.evaluate(/** @type {Expression} */ (expression.arguments[0]));
if (arg.is_known) {
this.values.add(Number(arg.value));
} else if (arg.is_number) {
this.values.add(NUMBER);
} else {
for (let value of arg.values) {
switch (value) {
case STRING:
case NUMBER:
case UNKNOWN:
this.values.add(NUMBER);
break;
default:
this.values.add(Number(value));
}
}
this.values.add(NUMBER);
}
} else {
this.values.add(0);
Expand All @@ -432,20 +420,8 @@ class Evaluation {
const arg = scope.evaluate(/** @type {Expression} */ (expression.arguments[0]));
if (arg.is_known) {
this.values.add(String(arg.value));
} else if (arg.is_number || arg.is_string) {
this.values.add(STRING);
} else {
for (let value of arg.values) {
switch (value) {
case STRING:
case NUMBER:
case UNKNOWN:
this.values.add(STRING);
break;
default:
this.values.add(String(value));
}
}
this.values.add(STRING);
}
} else {
this.values.add('');
Expand Down