IRGen: honour -static-libclosure in block creation
#81754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
I'm not sure about the best way to handle the special casing needing for the runtime functions. On Windows, the code generation for libclosure is controlled through |
When creating a block, ensure that we correctly associate the DLL Storage on the `_NSConcreteStackBlock` root object declaration based upon whether we are generating code with `-static-libclosure` being passed to the clang importer or not.
|
@swift-ci please smoke test |
aschwaighofer
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a block, ensure that we correctly associate the DLL Storage on the
_NSConcreteStackBlockroot object declaration based upon whether we are generating code with-static-libclosurebeing passed to the clang importer or not.