[6.2] Fix deserialization of lifetime dependencies on ast function types #81917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meg-gupta
force-pushed
the
fixdeserializationcp
branch
from
5b39c5c to
a5ce5b7
Compare
|
@swift-ci test |
slavapestov
reviewed
Jun 3, 2025
| @@ -231,6 +231,24 @@ class LifetimeDependenceInfo { | |||
| || !conditionallyAddressableParamIndices | |||
| || conditionallyAddressableParamIndices->isDisjointWith( | |||
| addressableParamIndices))); | |||
| #ifndef NDEBUG | |||
There was a problem hiding this comment.
Instead, use if (CONDITIONAL_ASSERT_enabled())
meg-gupta
force-pushed
the
fixdeserializationcp
branch
from
a5ce5b7 to
637f8ef
Compare
|
@swift-ci test |
|
@swift-ci test windows platform |
1 similar comment
|
@swift-ci test windows platform |
tbkka
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: While deserializing AST function types FunctionType and GenericFunctionType which include lifetime dependencies and an implicit self parameter, we don't correctly populate ASTExtInfoBuilder.lifetimeDependencies. We end up reading one dependency less due to incorrect index calculation.
Unlike SILFunctionType, AST function types FunctionType and GenericFunctionType do not include implicit self in their param list. They represent methods with implicit self as:
(Self) -> (Args...) -> Resultand don't have any information to indicate they may have implicit self. Since we use number of parameters while deserializing lifetime dependencies, we go wrong for such function types.Serialize the length of parameter indices, so that lifetime dependencies can be deserialized to that length.
Scope: Affects ~Escapable types
Testing: Added test involving conditionally ~Escapable
ResultRisk: Low
Issue: rdar://151768216
Main PR: #81879
Reviewer: @atrick