Skip to content

[6.2] [CS] Check hasType in isPlaceholderVar #81938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

hamishknight
Copy link
Contributor

6.2 cherry-pick of #81901

  • Explanation: Fixes an assertion failure that could occur when referencing a dollar-prefixed name in another file from within a closure
  • Scope: Affects references to dollar-prefixed names from within a closure
  • Issue: rdar://146383201
  • Risk: Low, adds a null check
  • Testing: Added tests to test suite
  • Reviewer: Pavel Yaskevich

Patterns assert that a type is set in `getType`, check `hasType`
before querying.

rdar://146383201
@hamishknight hamishknight requested a review from bnbarham June 3, 2025 10:35
@hamishknight hamishknight requested a review from a team as a code owner June 3, 2025 10:35
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels Jun 3, 2025
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight enabled auto-merge June 3, 2025 17:49
@hamishknight hamishknight merged commit 0a9c577 into swiftlang:release/6.2 Jun 3, 2025
5 checks passed
@hamishknight hamishknight deleted the hastype-6.2 branch June 3, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants