Fix utils/download-unpublished-toolchains.py URL parsing
#81939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current `.removeprefix` invocation is not resilient against any input preceding the `Toolchain: ` pattern, which in the logs currently includes timestamps. Additionally, for easier testing this script now supports a new `--dry-run` flag that infers toolchain URL, but doesn't download it.
MaxDesiatov
added
python
|
@swift-ci smoke test |
|
@swift-ci test macos |
edymtt
approved these changes
Jun 3, 2025
kateinoigakukun
approved these changes
Jun 4, 2025
|
@swift-ci test macos |
|
@swift-ci smoke test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
.removeprefixinvocation is not resilient against any input preceding theToolchain:pattern, which means logs that include timestamps (IIUC all of them) can't be parsed.Additionally, for easier testing this script now supports a new
--dry-runflag that infers toolchain URL, but doesn't download it.